feat: ignore missing tsconfig #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
reviewed
Mar 24, 2023
src/types.ts
Outdated
| @@ -38,6 +38,12 @@ export interface PluginOptions { | |||
| * necessary. | |||
| */ | |||
| parseNative?: boolean | |||
| /** | |||
| * Enable use of `tsconfck.resolveWithEmptyIfConfigNotFound`. | |||
There was a problem hiding this comment.
Seems odd to mention an implementation detail in the description
There was a problem hiding this comment.
That's right, I'd rather copy the docs in tsconfck instead
aleclarson
requested changes
Apr 10, 2023
There was a problem hiding this comment.
Some feedback to get this mergeable:
- remove
silentoption and setresolveWithEmptyIfConfigNotFoundto true - add a
debug("tsconfig not found: %s", project)call before the return on line 96
Once that's done, I will release as a minor, since I don't think anyone is relying on the current behavior.
aleclarson
changed the title
|
Thanks for the update @aleclarson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #96