Add WithPreWrapper option #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
changed the title
bep
changed the title
|
A friendly bump. |
alecthomas
requested changes
Nov 20, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on cleaning up Hugo's highlighting code and use https://github.com/yuin/goldmark-highlighting. We have had some ugly replace logic to get the "correct" HTML wrappers. We tried to fix this with a "wrapper func" in goldmark-highlighting, but I totally forgot the
LineNumbersInTableoption I assume thatPreventSurroundingPrewas added to allow custom pre wrappers, but that is hard to do when the code lives inside a table.This PR should solve Hugo's problem, and It's hopefully not too intrusive...
/cc @yuin