Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithPreWrapper option #300

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Add WithPreWrapper option #300

merged 1 commit into from
Nov 20, 2019

Conversation

bep
Copy link
Contributor

@bep bep commented Nov 18, 2019

I'm working on cleaning up Hugo's highlighting code and use https://github.com/yuin/goldmark-highlighting. We have had some ugly replace logic to get the "correct" HTML wrappers. We tried to fix this with a "wrapper func" in goldmark-highlighting, but I totally forgot the LineNumbersInTable option I assume that PreventSurroundingPre was added to allow custom pre wrappers, but that is hard to do when the code lives inside a table.

This PR should solve Hugo's problem, and It's hopefully not too intrusive...

/cc @yuin

@bep bep changed the title Add WithPreWrapper option WORK IN PROGRESS: Add WithPreWrapper option Nov 18, 2019
@bep bep changed the title WORK IN PROGRESS: Add WithPreWrapper option Add WithPreWrapper option Nov 18, 2019
@bep bep mentioned this pull request Nov 19, 2019
@bep
Copy link
Contributor Author

bep commented Nov 20, 2019

A friendly bump.

Copy link
Owner

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, just a minor request.

formatters/html/html.go Outdated Show resolved Hide resolved
@alecthomas alecthomas merged commit d3926cc into alecthomas:master Nov 20, 2019
@alecthomas
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants