Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Goldmark #6484

Merged
merged 1 commit into from Nov 23, 2019
Merged

Add Goldmark #6484

merged 1 commit into from Nov 23, 2019

Conversation

bep
Copy link
Member

@bep bep commented Nov 6, 2019

See #5963

@bep
Copy link
Member Author

bep commented Nov 6, 2019

@yuin quick question; is Markdown.Convert (in the one you get from goldmark.New) thread safe?

@yuin
Copy link

yuin commented Nov 7, 2019

@bep Yes it is. Parsers and renderers are designed as stateless. Stateful data is stored in parse.Context and passed as arguments.

@bep bep force-pushed the goldmark2 branch 16 times, most recently from 5e79ccd to d0fc67d Compare November 12, 2019 18:39
@bep bep force-pushed the goldmark2 branch 11 times, most recently from b34a287 to 16257f1 Compare November 17, 2019 16:51
@bep bep force-pushed the goldmark2 branch 3 times, most recently from f303050 to 16f5cc3 Compare November 19, 2019 10:42
@bep
Copy link
Member Author

bep commented Nov 19, 2019

This needs some manual testing, but the implementation of this is now done, I'm now just waiting for some upstream merges:

Which is both a little out of my direct control.

@bep bep force-pushed the goldmark2 branch 7 times, most recently from 1002a66 to 0738fee Compare November 23, 2019 11:06
@bep bep changed the title WIP: Add Goldmark Add Goldmark Nov 23, 2019
@bep bep force-pushed the goldmark2 branch 2 times, most recently from 0c9f858 to c16562e Compare November 23, 2019 12:56
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
@bep bep merged commit bfb9613 into gohugoio:master Nov 23, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants