Add Goldmark #6484
Add Goldmark #6484
Conversation
|
@yuin quick question; is |
|
@bep Yes it is. Parsers and renderers are designed as stateless. Stateful data is stored in |
bep
force-pushed
the
goldmark2
branch
16 times, most recently
from
5e79ccd
to
d0fc67d
Compare
bep
force-pushed
the
goldmark2
branch
11 times, most recently
from
b34a287
to
16257f1
Compare
bep
force-pushed
the
goldmark2
branch
3 times, most recently
from
f303050
to
16f5cc3
Compare
|
This needs some manual testing, but the implementation of this is now done, I'm now just waiting for some upstream merges: Which is both a little out of my direct control. |
bep
force-pushed
the
goldmark2
branch
7 times, most recently
from
1002a66
to
0738fee
Compare
bep
force-pushed
the
goldmark2
branch
2 times, most recently
from
0c9f858
to
c16562e
Compare
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo. If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration: ```toml [markup] defaultMarkdownHandler="blackfriday" ``` Fixes gohugoio#5963 Fixes gohugoio#1778 Fixes gohugoio#6355
There was a problem hiding this comment.
Hi @bep, thanks for this great work!
Was wondering if you can help me understand the implication a bit more.
I am in the middle of debugging a code block rendering issue.
For a code block starts with ```sequence, my theme(even) will be able to treat it as a signal to invoke js lib to draw a sequence diagram.
The code stopped working because my sequence diagram code block is now treated as language-fallback vs before it was treated as language-sequence.
Do you know the correct part of code I should read in order to ask hugo to autogen the language-sequence vs automatically resolve to language-fallback?
My goal is to make sure I can instruct the hugo engine to retain whatever I specified as the code language instead of changing it to fallback.
There was a problem hiding this comment.
@mkmojo,
Please don't ask questions on commits, especially commits from 8 months ago. I'd suggest you use the discussion forums for help with your question.
There was a problem hiding this comment.
@mkmojo,
Please don't ask questions on commits, especially commits from 8 months ago. I'd suggest you use the discussion forums for help with your question.
Sure, still learning the rules of the community.
Thanks for point me to the right direction.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
See #5963