Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActionScript 3 content analyser #826

Closed

Conversation

gandarez
Copy link
Contributor

This PR adds content analyser for Action Script 3 as implemented in Pygments.

@alecthomas
Copy link
Owner

alecthomas commented Aug 21, 2023

Okay, I think if there are going to be a lot of these regex-based analysers, then they should be in the XML as I suggested before. There should also be a general test harness for these rather than custom one-off tests. I'll do this, then please reopen a PR using that mechanism.

@alecthomas alecthomas closed this Aug 21, 2023
@gandarez
Copy link
Contributor Author

Please let me know since I'm revamping my current app to use v2 and didn't count you'd change this logic.

@alecthomas
Copy link
Owner

Actually there are already analyser file-driven tests in testdata/analysers

alecthomas added a commit that referenced this pull request Aug 21, 2023
The `<analyse>` element contains a regex to match against the input, and
a score if the pattern matches.

The scores of all matching patterns for a lexer are summed.

Replaces #815, #813 and #826.
alecthomas added a commit that referenced this pull request Aug 21, 2023
The `<analyse>` element contains a regex to match against the input, and
a score if the pattern matches.

The scores of all matching patterns for a lexer are summed.

Replaces #815, #813 and #826.
@alecthomas
Copy link
Owner

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants