Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unicode translation #278

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Conversation

jd
Copy link
Contributor

@jd jd commented Apr 13, 2017

Unicode translation added in commit added in
5e3bf14 heavily broke Python 2. A basic test
such as provided in test_unicode_as_key in this patch does not work anymore
because of that conversion.

This patches goes back to the behaviour that was in 0.9.

Unicode translation added in commit added in
5e3bf14 heavily broke Python 2. A basic test
such as provided in test_unicode_as_key in this patch does not work anymore
because of that conversion.

This patches goes back to the behaviour that was in 0.9.
@jd
Copy link
Contributor Author

jd commented Apr 13, 2017

@alecthomas @tusharmakkar08 if you could look into that quickly, that broke entirely some of our software in OpenStack :(

@coveralls
Copy link

coveralls commented Apr 13, 2017

Coverage Status

Coverage decreased (-0.06%) to 95.652% when pulling 44fa104 on jd:jd/fix-unicode into cd0be17 on alecthomas:master.

@tusharmakkar08 tusharmakkar08 merged commit 1b4ea20 into alecthomas:master Apr 13, 2017
@tusharmakkar08
Copy link
Collaborator

tusharmakkar08 commented Apr 13, 2017

Hey @jd

I will revert back the change.
@jmwri : Can you please create a PR where you only change error.py? Reopening #218 .

Thanks.

@tusharmakkar08
Copy link
Collaborator

Hey @jd

Please update voluptuous version to 0.10.5

Thanks.

@jd
Copy link
Contributor Author

jd commented Apr 13, 2017

Thanks for the fast merge @tusharmakkar08 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants