New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] - Use new submenu support for editor commands #351
Comments
Hi @eamodio , Thanks for reporting. I was thinking about embracing this new API, right after it was made public. I just wonder how extensions, and VS Code itself, would deal with it. Would it simply update the extension to use submenus, or should give the user the possibility to choose the appearance, via settings? Personally, I have mixed feelings. I like direct access to most used context menu items, but I don’t like looong context menus, neither multi-level (more than 2) in context menu. Just out of curiosity, how are you dealing with GitLens, or VS Code itself. Are you simply moving it to submenus or providing settings ? Thank you |
I have updated GitLens (in the very soon to be released v11) to take advantage of submenus to considerably reduce the number of items shown -- and so far I've been really happy with the results (I've even used some menu options more than I have in the past). I haven't offered a choice in it (just whether the show the menu items/submenus themselves). Yeah, its a trade off -- and I would definitely limit it to a single level of submenus (no submenus in submenus). |
That's great! Thank you for your feedback 👍 |
Hi @eamodio , I just started to work on this, but found an issue that maybe you faced while updating GitLens. Today I have those entries in that Context Menu. These entries refers to the very main commands of the extension (available in the But, If I move these entries to a new To solve this, I should contribute new commands, without the The keybinding itself keeps working, because the original commands are still there, available in the If I was able to define alternative title for commands, when attached in the Context Menu, I could simply remove the Am I missing something? Thank you |
Sorry for the long delay in getting back to you here. Since these menu items are now in a submenu labeled Bookmarks, you don't need the Bookmark: prefix, so you can just remove that prefix from the command title. And to keep the prefix in the command palette, add Hope that helps! |
The text was updated successfully, but these errors were encountered: