Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Even after uninstalling/reloading/reinstalling Bookmarks, entries are present in Bookmarks sidebar that don't exist #481

Closed
daniel347x opened this issue Nov 3, 2021 · 2 comments

Comments

@daniel347x
Copy link

Environment/version

  • Extension version: 13.2
  • VSCode version: 1.59.0
  • OS version: Windows 10

Steps to reproduce

  1. Uninstall Bookmarks extension
  2. Quit Visual Code
  3. Run Visual Code
  4. Install Bookmarks Extension
  5. Open Bookmarks sidebar

At this point, I still see two "zombie" entries present:

image

When you click on one of the zombies, it DOES take you to those lines of code, but there is no bookmark present (there is no 'bookmark' icon in the gutter):

image

If you add a bookmark at that same line of code, a new entry appears in the bookmark sidebar (duplicating the zombie entry):

image

...and now you do see the 'bookmark' icon in the gutter:

image

It is impossible to edit or delete the zombie entries; if you try, a toast popup in Visual Code appears saying that the extension responsible for the command had an error:

image

Thanks for taking a look!

@daniel347x daniel347x added the bug label Nov 3, 2021
@alefragnani
Copy link
Owner

Hi @daniel347x ,

I didn't noticed this "zombie" behavior before, and had no success trying to reproduce. At first I thought it could be related to the column position (the stored position to be larger than the actual line length), but no success either.

About the "missing bookmark icon in gutter", there is a recent issue #450, but I couldn't reproduce either. Before this reports, the only missing icon was from the Side Bar, which in the end appeared to be a VS Code issue (also reported in VS Code repo) which required a "force reinstall" (Uninstall Extension - Close VSCode - Open VSCode - Install Extension) in order to fix.

Just out of curiosity:

  • This error started to happen on recent releases, or are you starting to use the extension?
  • Which are your bookmarks settings?
  • What happens if you run the Bookmarks: List command right after you open the folder with the "zombie bookmarks". Are you able to navigate to each bookmark, or does it display any error?

Thank you

@alefragnani
Copy link
Owner

I'm closing this issue because no new comments has been added since my last question.
Feel free to reopen/comment if the error still occurs.

Thanks for your understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants