Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spain Spanish translation #427

Merged
merged 2 commits into from Apr 24, 2021

Conversation

guillerpsanchez
Copy link
Contributor

I have seen that the Spanish translation is not available yet, and I want to help the project with it.

I am not sure if it only need the json with the translation or it needs further changes in the code.

@alefragnani
Copy link
Owner

Hi @guillerpsanchez ,

First of all, thank you for the PR.

Yes, that’s all you need to do to translate the extension, at least the “translatable” pieces 😬 . The extension also has messages and other resources inside, which can’t be translated yet, but this may change in the future.

Thank you

@alefragnani
Copy link
Owner

Hi @guillerpsanchez ,

Which Language Pack are you using on your VS Code installation, in order to VS Code appear in Spanish?

I mean, I installed the Spanish Language Pack from Microsoft (https://marketplace.visualstudio.com/items?itemName=MS-CEINTL.vscode-language-pack-es) and VS Code appeared Spanish, but the extension didn't. Then, I tried to change the language and noticed VS Code provides en and es (instead of es-es). I renamed the file to package.nls.es.json and it worked.

Thank you

@alefragnani alefragnani added PR needs update The PR needs review by the author and removed PR needs test labels Apr 22, 2021
@guillerpsanchez
Copy link
Contributor Author

guillerpsanchez commented Apr 23, 2021

Hello,@alefragnani

I was using and old language package, as you said the es is the correct one, sorry for the mistake.

If tou want tomorrow i can update the PR with the right name.

Have a nice day.

@alefragnani
Copy link
Owner

No problem.. it happens.

Thanks, I appreciate that 👍. Once you update the PR I can test it again and merge, so it would be available in the next release

Thank you

@guillerpsanchez
Copy link
Contributor Author

Hello @alefragnani ,

I have updated the PR with a new commit, it´s the first time I do it so I´m not sure if I have done it right.

Thank you and have a nice day.

@alefragnani alefragnani added PR needs test PR tested and removed PR needs update The PR needs review by the author PR needs test labels Apr 24, 2021
@alefragnani
Copy link
Owner

Thanks @guillerpsanchez . It worked perfectly.

Stay tuned for the next release.

@alefragnani alefragnani merged commit 7c535cd into alefragnani:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants