Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for paste. #41

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Conversation

dudeNumber4
Copy link

@dudeNumber4 dudeNumber4 commented Mar 5, 2022

I just can't figure out how to debug my command. I don't know how/where registerCommands is supposed to get called. Reference feature request. Disregard - I had never run vscode:prepublish

Copy link
Owner

@alefragnani alefragnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the PR with the provided review.

Once updated, I'll try out.

Thank you

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@alefragnani
Copy link
Owner

Hi @dudeNumber4 ,

First of all, thank you for your PR. I made a few comments, and would like you to take a look. Those 3 files README.md, CHANGELOG.md and package-lock.json could be reverted (removed from PR) and only package.json needs update. The extension's code itself, seems to be ok.

About debugging, I've noticed this issue after updating the extension to use esbulid. It requires you to be built (npm run build) every time you update the code, because there it has no watch feature. I'm reverting this change in #43 , because web extension samples uses WebPack for easier packaging. With WebPack, which scripts supports watch, whenever you change the code, the debug works as expected.

I can merge #43 into main, so you could update your branch and retry with WebPack. Otherwise, simply follow these esbuild instructions to properly debug the extension. What do you prefer?

Thank you

@alefragnani alefragnani self-assigned this Mar 16, 2022
@alefragnani alefragnani added this to the March 2022 milestone Mar 16, 2022
@alefragnani alefragnani linked an issue Mar 16, 2022 that may be closed by this pull request
@dudeNumber4
Copy link
Author

I was able to debug; it should be good to merge.

@dudeNumber4
Copy link
Author

Is there anything else blocking this from being merged?

@alefragnani
Copy link
Owner

Not at all.

Just my free time to test/merge 😉

@alefragnani
Copy link
Owner

My plans are for this weekend

@alefragnani alefragnani merged commit 32dbb0f into alefragnani:master Mar 29, 2022
@alefragnani
Copy link
Owner

Just published v3.7.0 with your PR.

This new release also works on the web (github.dev and vscode.dev)

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Add Paste
2 participants