Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Function Status Assertion #20

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Conversation

joelhamiltondev
Copy link
Contributor

Wrote assertion to check that status of a given step function execution is as expected.

}

async runExecution(stateMachineName: string, input: any): Promise<any> {
// this.stepFunctions = new AWSStepFunctions();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code still needed?

const executionList = await this.stepFunctions
.listExecutions(listExecParams)
.promise();
while (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a comment explaining the polling or split this into a separate function

```
await expect("STATE_MACHINE_NAME").toHaveCompletedExecutionWithStatus("STATUS");
```

## Helpers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add helper to read me

@agwhi agwhi merged commit 5f06b68 into main Jan 26, 2022
@agwhi agwhi deleted the feat/step-function-status-assertion branch January 26, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants