Sort prs by added date #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
force-pushed
the
sort-prs-by-added-date
branch
from
c7e895b
to
0373817
Compare
alejandro5042
requested changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before separating PR dashboard rows into different buckets (e.g. Drafts, Approved, etc), set their relative order based on when the user was (most recently) added to the review.
The most direct way I know of to get that information is by looking for the comment thread that announces when a reviewer is added to the PR. We were already querying the threads for PRs that the user had approved (in order to check for "notable activity"), but now we have to do this for all PRs the user is on. That will result in a performance hit, but it should be acceptable.