Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin2txt: Remove extra new line when version is printed, optimize Makefile as well #193

Merged
merged 3 commits into from Apr 10, 2023

Conversation

kobenairb
Copy link
Contributor

Hi all,

Some small improvements for bin2txt. I slighty optimized the Makefile and remove useless new lines in bin2txt.c when printing version.

Here the changes performed on the Makefile:

  • Uses := instead of = for variable assignment to prevent unnecessary re-evaluation.
  • Uses $(shell date +%Y%m%d) instead of invoking the date command multiple times.
  • Uses automatic variable expansion to reduce duplication in the Makefile.

For the bin2txt.c source file, I just removed the \n\n for the PrintVersion function and applied some formating (extra spaces, sort include ...).

@RetroAntho RetroAntho merged commit a7b68f0 into alekmaul:develop Apr 10, 2023
@kobenairb kobenairb deleted the makefile_bin2txt branch April 13, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants