Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sysfs entry temp_offset #22

Merged
merged 8 commits into from Aug 15, 2022
Merged

Add sysfs entry temp_offset #22

merged 8 commits into from Aug 15, 2022

Conversation

leoratte
Copy link
Contributor

@leoratte leoratte commented Aug 3, 2022

Adds the sysfs entry temp_offset, which allows to set a correction offset for each temperature sensor.

  • Find and add control offsets for the other devices

aleksamagicka
aleksamagicka requested changes Aug 4, 2022
View reviewed changes
Copy link
Owner

@aleksamagicka aleksamagicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, though I noticed that temp sensor labels turned into temp1, temp2 etc. Not sure why.

I'll try to find the offset for other devices I have as well.

aquacomputer_d5next.c Show resolved Hide resolved
aquacomputer_d5next.c Show resolved Hide resolved
aquacomputer_d5next.c Outdated Show resolved Hide resolved
@leoratte
Copy link
Contributor Author

leoratte commented Aug 5, 2022

Improved upon your suggestions. The label was missing, as it was no longer visible.

@aleksamagicka
Copy link
Owner

Ah I see, that was it. Didn't look at the code very deeply yesterday, just tested.

LGTM now, I'll try to RE the offsets for other devices in the upcoming days.

@aleksamagicka
Copy link
Owner

Here are the offsets for other devices I have:

  • Farbwerk 360: temp offsets start at 0x08, control report size is 0x68A.
  • Octo: temp offsets start at 0xa, same as Quadro.
  • D5 Next: temp offsets start at 0x16.

@aleksamagicka
Copy link
Owner

aleksamagicka commented Aug 15, 2022 •
edited

Sorry, I've made two mistakes regarding the offsets - Farbwerk 360 control report size is 0x682, and D5 Next temp offset is actually 0x2D.

Please mark it as ready to review when you think you're done with the PR, and I'll merge and send to mainline!

@aleksamagicka aleksamagicka mentioned this pull request Aug 15, 2022
Open
8 tasks
@leoratte leoratte marked this pull request as ready for review August 15, 2022 14:49
@aleksamagicka aleksamagicka merged commit 0605047 into aleksamagicka:main Aug 15, 2022
@aleksamagicka
Copy link
Owner

Thanks!

@leoratte leoratte deleted the temp_offset branch August 16, 2022 07:54
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Oct 21, 2022
@aleksamagicka @intel-lab-lkp
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
01a646d 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Oct 24, 2022
@aleksamagicka @intel-lab-lkp
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
bd39096 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
jonhunter pushed a commit to jonhunter/linux that referenced this pull request Oct 27, 2022
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
6590614 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20221024151039.7222-1-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Nov 1, 2022
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
ee59d0b 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20221024151039.7222-1-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Nov 5, 2022
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
bf9b52f 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20221024151039.7222-1-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
aleksamagicka added a commit that referenced this pull request Nov 7, 2022
@aleksamagicka
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
237dd99 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] #22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Nov 7, 2022
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
827717c 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20221024151039.7222-1-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Nov 13, 2022
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
fcd0d10 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20221024151039.7222-1-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Nov 15, 2022
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
3d611ab 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20221024151039.7222-1-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Nov 25, 2022
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
5d79376 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20221024151039.7222-1-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
mj22226 pushed a commit to mj22226/linux that referenced this pull request Dec 2, 2022
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
abb7048 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20221024151039.7222-1-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
mj22226 pushed a commit to mj22226/linux that referenced this pull request Dec 6, 2022
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets
662d20b 
Add support for reading and writing temperature sensor offsets
on the Aquacomputer D5 Next, Farbwerk 360, Octo and Quadro,
for which the needed offsets are known. Implemented by
Leonard Anderweit [1].

[1] aleksamagicka/aquacomputer_d5next-hwmon#22

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20221024151039.7222-1-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksamagicka aleksamagicka aleksamagicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leoratte @aleksamagicka