Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159 Applied the same fix as in #19 in order to solve the pom.xml ver… #160

Conversation

iulvalSPL
Copy link
Contributor

…sion conflict when a hotfix branch gets merged into a release branch

… solve the pom.xml version conflict when a hotfix branch gets merged into a release branch
@aleksandr-m
Copy link
Owner

@iulvalSPL I assume it happens because both commitDevelopmentVersionAtStart and useSnapshotInHotfix are set to true. Can you add an if statement like in this commit.

@iulvalSPL
Copy link
Contributor Author

iulvalSPL commented Feb 19, 2019

@aleksandr-m I think those two fields do not matter that much.
What matters is having the hotfix branch with a different version than the release branch.
When you create a hotfix branch, you get the option of overwriting the default version value.

What is the hotfix version? [2.13]: 2.13.1

If you change this default (like we do), then you will get a conflict with or without commitDevelopmentVersionAtStartand useSnapshotInHotfix

I am thinking to add an if to check if the hotfix version is different than the release version instead.

I have committed two integration tests to address the non default hotfix version scenarios, with or without commitDevelopmentVersionAtStartand useSnapshotInHotfix

… the hotfix version is different than the release version. Improve README.md and add ITs for this issue.
@aleksandr-m
Copy link
Owner

Different versions doesn't mean automatically that there will be merge conflicts. Maybe if on commitDevelopmentVersionAtStart and useSnapshotInHotfix is more appropriate. Or maybe we should check which version is ahead and use that version?

Not sure that current solution is good for all use cases. Nevertheless, let's merge it and see what next issues arise with that.

@aleksandr-m aleksandr-m merged commit b54f0d5 into aleksandr-m:master Mar 18, 2019
@iulvalSPL iulvalSPL deleted the issue159-fix-conflict-hotfix2release branch March 19, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants