Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add manual instructions to README #69

Merged
merged 3 commits into from
Aug 19, 2023

Conversation

fabricionaweb
Copy link
Contributor

Svelte docs suggest us to use dotenv dependency to load from the .env file https://kit.svelte.dev/docs/adapter-node#environment-variables

I followed the steps similar to the Dockerfile, I just mention the v18.14.0 because it is the first version to comes with NPM 9 (which uses the lock-file 3) so that may keep things more consistent and error prone.

I also splitted the Docker instructions in two, as I think not everyone needs compose.

This may closes #45 but yet people needs to built their own daemon... Maybe another MR I can add some daemon examples like Systemd and OpenRC

@aleksilassila
Copy link
Owner

aleksilassila commented Aug 16, 2023

Lmk when this is ready and I'll review and merge 👍

@fabricionaweb
Copy link
Contributor Author

fabricionaweb commented Aug 17, 2023

Its ready... the --restart on docker cli is optional, idk if worth to present it but I left to be similar to compose... there is also the -d to run in background that maybe can be added to the cli command, not sure but you decided what is better :D

@aleksilassila aleksilassila merged commit 9817b2b into aleksilassila:master Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux Support
2 participants