Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bugfixes #125

Merged
merged 3 commits into from
Aug 20, 2023
Merged

🐛 Bugfixes #125

merged 3 commits into from
Aug 20, 2023

Conversation

aleksul
Copy link
Owner

@aleksul aleksul commented Aug 20, 2023

Change Summary

  • Usage of performance counter to log started_when and finished_when was inappropriate - use time_ns instead
  • Fix for Result buckets, containing exceptions - report exception type in result.exception and value of exception in result.data
  • Add a PDM script for fast tests execution

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • My PR is ready to review

@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d19ac12
Status: ✅  Deploy successful!
Preview URL: https://a9bfbd4b.repid.pages.dev
Branch Preview URL: https://bugfixes.repid.pages.dev

View logs

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #125 (d19ac12) into main (d203372) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         1986      1989    +3     
=========================================
+ Hits          1986      1989    +3     
Files Changed Coverage Δ
repid/data/_buckets.py 100.00% <ø> (ø)
repid/_processor.py 100.00% <100.00%> (ø)
repid/actor.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aleksul aleksul merged commit 6139a9f into main Aug 20, 2023
15 checks passed
@aleksul aleksul deleted the bugfixes branch August 20, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant