Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: could not start Instances from command line #597

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Conversation

olethanh
Copy link
Collaborator

Problem happened when launching with --run-fake-instance

Solution: Adapt to new VMPool API that take a loop Also fix benchmarks function

Problem  happened when launching with --run-fake-instance
Solution: Adapt to new VMPool API that take a loop
Also fix benchmarks function
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 43.80%. Comparing base (0f77070) to head (4e46dcc).
Report is 2 commits behind head on main.

Files Patch % Lines
src/aleph/vm/orchestrator/cli.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   43.83%   43.80%   -0.03%     
==========================================
  Files          55       55              
  Lines        4944     4947       +3     
  Branches      585      585              
==========================================
  Hits         2167     2167              
- Misses       2658     2661       +3     
  Partials      119      119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/aleph/vm/orchestrator/cli.py Outdated Show resolved Hide resolved
src/aleph/vm/orchestrator/cli.py Outdated Show resolved Hide resolved
Copy link

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@hoh
Copy link
Member

hoh commented Apr 16, 2024

Is there any test to ensure that this keeps working ?

src/aleph/vm/orchestrator/cli.py Outdated Show resolved Hide resolved
@olethanh
Copy link
Collaborator Author

Is there any test to ensure that this keeps working ?

no that I know of. We don't really test the CLI via unit test and this isa debug method

@nesitor nesitor requested a review from hoh April 24, 2024 14:53
@hoh hoh merged commit 18bb56f into main Apr 25, 2024
18 of 20 checks passed
hoh pushed a commit that referenced this pull request Apr 26, 2024
Problem: could not start Instances from command line

Problem  happened when launching with --run-fake-instance
Solution: Adapt to new VMPool API that take a loop
Also fix benchmarks function
@Psycojoker Psycojoker deleted the ol-fix-broken-program branch July 24, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants