Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Till/2400 message banner #2421

Merged
merged 15 commits into from
Sep 19, 2022
Merged

Till/2400 message banner #2421

merged 15 commits into from
Sep 19, 2022

Commits on Sep 1, 2022

  1. Change default font weight to regular 

    Using a light font weight reduces legibility and contrast, which makes it difficult to read some UI texts.
    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    d5e769f View commit details
    Browse the repository at this point in the history

  2. Load message on initialization and poll thereafter 

    Disatching the action to fetch messages in the router is a little unintuitive to me, but we already do the same for the metadata in that place, so I thought it would be good to be consistent.
    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    77cb0ad View commit details
    Browse the repository at this point in the history

  3. Add utility component to render relative dates

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    839132e View commit details
    Browse the repository at this point in the history

  4. Display message banner

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    13258f4 View commit details
    Browse the repository at this point in the history

  5. Display message defined via environment variable 

    There already is a way to set a app-wide message banner via the `ALEPH_APP_BANNER` environment variable. Users will still be able to use that approach and it takes precedences over other messages.
    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    4b72483 View commit details
    Browse the repository at this point in the history

  6. Refetch messages every 15 minutes

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    bc1a5b7 View commit details
    Browse the repository at this point in the history

  7. Set up test with React Testing Library

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    100e858 View commit details
    Browse the repository at this point in the history

  8. Add test for message banner component

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    d82f02d View commit details
    Browse the repository at this point in the history

  9. Do not display expired messages

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    a6827e5 View commit details
    Browse the repository at this point in the history

  10. Remove home screen warning callout 

    This is another way to display a warning message (only on the home page though). It was introduced in #1907 for a similar purpose (to inform users that anonymous access is temporarily disabled).

As we now have two ways to set an app-wide message banner (via the `APP_BANNER` env variable and by configuring a messages endpoint), I think we can now remove this feature.
    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    4e3410d View commit details
    Browse the repository at this point in the history

  11. Make messages endpoint configurable via env variable

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    82a85c3 View commit details
    Browse the repository at this point in the history

  12. Update env template to include message banner configuration

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    3f2c80c View commit details
    Browse the repository at this point in the history

  13. Render HTML in message bodies

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    224b1ea View commit details
    Browse the repository at this point in the history

  14. Fix date comparision

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    6f7e8ad View commit details
    Browse the repository at this point in the history

  15. Fix error color

    @tillprochaska
    tillprochaska committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    552f312 View commit details
    Browse the repository at this point in the history