Allow users to add timeline items with times #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillprochaska
force-pushed
the
fix/3009-fix-datetime-values-timelines
branch
from
ace1c14
to
12acac8
Compare
…and form validation
Rosencrantz
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FtM supports times in date properties (see docs), but when adding items to a timeline in Aleph, you can’t add a time.
Additionally, if a timeline contains an item with a datetime value, an unhandled error occurs when switching to the chart view.
This PR fixes both issues. When adding a new timeline item, the form now allows entering values like
2023-05-02T00:00:00or2023-05-02 00:00.When parsing those dates, we now simply ignore the time part. This also ensures that the chart view renders successfully.
Closes #3009
To do:
patternattribute in form an for parsing inImpreciseDate?