Fix search highlights disappearing when opening entity previews #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When searching, we keep the search results in the Redux store in a structure similar to the following:
```json
{
"entities": {
"abc123": {
"id": "abc123",
"schema": "Company",
"highlight": "<em>Twitter</em> is an online social media and social networking service."
}
},
"results": {
"entities?filter:schemata:Company&highlight=true&limit=30&q=twitter": {
"total": 1,
"page": 1,
"results": ["abc123"]
}
}
}
```
After clicking on one of the search results, we load detailed entity data and use the detailed data to replace the (partial) entity data from the initial search request. However, the response from the second request does not contain the search highlight, i.e. the highlight is removed from the state when loading additional entity data.
We can work around this by merging data instead of replacing data. It does still feel a bit like a hacky workaround, but a proper solution would require making significant changes to our state management solution (probably replacing it with an off-the-shelf solution).
Fix #2268
When selecting/clicking on a result on a search results page, we change the background color to dark blue.
tillprochaska
force-pushed
the
fix/2268-search-highlight-disappears
branch
from
90b29f0
to
749c943
Compare
tillprochaska
changed the title
Rosencrantz
approved these changes
May 26, 2023
| @@ -47,7 +47,7 @@ $aleph-sidebar-width: $aleph-grid-size * 35; | |||
| $aleph-sidebar-sm-width: $aleph-grid-size * 20; | |||
| $aleph-sidepane-md-width: $aleph-grid-size * 27; | |||
|
|
|||
| $aleph-text-highlight-color: yellow; | |||
| $aleph-text-highlight-color: rgba($gold5, 0.5); | |||
There was a problem hiding this comment.
Is this really $gold5 or is it actually $dirtyMustard? Joking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching, we keep the search results in the Redux store in a structure similar to the following:
{ "entities": { "abc123": { "id": "abc123", "schema": "Company", "highlight": "<em>Twitter</em> is an online social media and social networking service." } }, "results": { "entities?filter:schemata:Company&highlight=true&limit=30&q=twitter": { "total": 1, "page": 1, "results": ["abc123"] } } }After clicking on one of the search results, we load detailed entity data and use the detailed data to replace the (partial) entity data from the initial search request. However, the response from the second request does not contain the search highlight, i.e. the highlight is removed from the state when loading additional entity data.
We can work around this by merging data instead of replacing data. It does still feel a bit like a hacky workaround, but a proper solution would require making significant changes to our state management solution (probably replacing it with an off-the-shelf solution).
Fix #2268