Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps version of FTM libs, SQLAlchemy, Flask and related to latest #3160

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

catileptic
Copy link
Contributor

@catileptic catileptic commented Jun 20, 2023

The versions of the following packages were increased to the latest versions: followthemoney, followthemoney-store, servicelayer. Due to the fact that all 3 libraries use a newer version of SQLAlchemy, the versions of the following packages were also bumped to latest: Flask, Flask-SQLAlchemy, SQLAlchemy, Flask-Babel.

The commit also includes minor refactorings necessary as a result of these version bumps.

  • core.py was refactored due to the Flask-Babel version bump as per the docs
  • migration.py, util.py and archive_api.py were refactored due to the SQLAlchemy version bump

archive.apy was refactored as per this interface change

@catileptic catileptic marked this pull request as draft June 20, 2023 14:04
@catileptic catileptic changed the title Version bump for FTM libs, SQLAlchemy, Flask and related Bumps version of FTM libs, SQLAlchemy, Flask and related to latest Jun 20, 2023
@catileptic
Copy link
Contributor Author

In order for the tests to pass, this PR in FTM needs to be merged and a new version of FTM needs to be released. Then, the FTM version in Aleph needs to be changed as well.

The versions of the following packages were increased to the latest versions: `followthemoney`, `followthemoney-store`, `servicelayer`. Due to the fact that all 3 libraries use a newer version of `SQLAlchemy`, the versions of the following packages were also bumped to latest: `Flask`, `Flask-SQLAlchemy`, `SQLAlchemy`, `Flask-Babel`.

The commit also includes minor refactorings necessary as a result of these version bumps.
* `core.py` was refactored due to the `Flask-Babel` version bump [as per the docs](https://python-babel.github.io/flask-babel/#configuration)
* `migration.py`, `util.py` and `archive_api.py` were refactored due to the `SQLAlchemy` version bump
@catileptic catileptic force-pushed the feature/sqlalchemy2-refactoring branch from 3fdf988 to b133daa Compare June 23, 2023 16:54
@catileptic catileptic marked this pull request as ready for review June 26, 2023 09:48
requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@stchris stchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me! 👏 Left some comments about some minor version bumps we might want to do at this time as well.

@catileptic catileptic merged commit 1524f5b into develop Jun 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants