Derive "safeHtml" from all "bodyHtml" values #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tillprochaska
force-pushed
the
fix/3163-safe-html
branch
from
d33f0a2
to
43055b4
Compare
tillprochaska
force-pushed
the
fix/3163-safe-html
branch
from
43055b4
to
380b69b
Compare
tillprochaska
force-pushed
the
fix/3163-safe-html
branch
from
380b69b
to
8c28a01
Compare
Rosencrantz
reviewed
Jul 10, 2023
| source_url = proxy.first("sourceUrl", quiet=True) | ||
| encoding = proxy.first("encoding", quiet=True) | ||
| entity["safeHtml"] = sanitize_html(html, source_url, encoding=encoding) | ||
| entity["safeHtml"] = [ | ||
| sanitize_html(value, source_url, encoding=encoding) for value in html |
There was a problem hiding this comment.
This is a utility function that we wrote, or a third party created?
There was a problem hiding this comment.
This is a utility we wrote wrapping the Cleaner class from lxml:
We need this fix to preserve the original order of email parts: alephdata/followthemoney#1148
tillprochaska
force-pushed
the
fix/3163-safe-html
branch
from
8c28a01
to
694f4de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge this. This is currently blocked until alephdata/followthemoney#1148 is merged and released.
Fixes #3163.