-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically switch apps when dApp asks for signing #55
Comments
That would be much better than the in-browser wallet IMO, as you can keep the browser state independent from the app state. |
You're mentioning a second issue that I know I was experiencing but didn't report - that after signing, you stay in the wallet. (it really should popup wallet to sign, then go back to browser after) |
Adding a feedback on this issue as I think it's relevant for prioritization: "this ONE issue though means I keep using kiwi browser (with extention wallet loaded) for dapps instead of the mobile wallet as it works smoother". |
The main issue is that when you sign something from chrome/mobile, nothing happens.. you have to know to switch manually to wallet and confirm the signing request that's there - and once you do, manually switch back.. It should popup the wallet on signing request and go back to the dapp/chrome tab when done signing |
Thanks for the feedback both of you. We'll prioritise the task accordingly! |
Regarding (3) on Android. The WalletConnect docs say:
Instead of the Kotlin SDK we are using the // Rainbow
redirect: {
native: 'rainbow://wc',
universal: 'https://rnbwapp.com/wc'
}
// Metamask
redirect: {
native: 'metamask://',
universal: 'https://metamask.app.link/'
} As expected, the custom schemes are also part of the respective They also register I tried registering the
It also works if I run
In the Kotlin example mentioned in the WalletConnect docs, I see that the redirect prop they use is:
The interesting thing about this is:
|
Wonderful research! I'd go with the simplest option: "Simply display a success message that says "Success, you can go back to your browser" and not try to automatically switch to the mobile browser". This has many advantages:
This flow is used in many payments apps btw, like twint in CH. WDYT? We can talk more about that tmr. |
I agree. That will take care of tasks (2) and (4) for both Android and iOS. We still need to figure out (1) for iOS and and (3) for both Android and iOS. |
This article makes me think that the |
To solve the point (1) for iOS, I've been working on registering our mobile wallet app to the WalletConnect Explorer, but I am stuck at this step. "Alephium" is not listed in the supported chains: Maybe we need to register our chain?
|
@mvaivre I moved this to the following release. However, there doesn't seem to be a high demand for the remaining subtasks (iOS-related). Besides, as the commend above mentions, we need to first register our app with WC Cloud. I propose we de-prioritize this task until it's really needed by our community (basically remove it from our milestones for now and focus on other tasks). |
ping @mvaivre |
We need to re-prioritize this issue due to popular demand. |
Subtasks
Android
wc
as thescheme
of our mobile app (see Expo docs) so that our app shows in the Android app selector when clicking on the "Connect" button in the dApp's WalletConnect modal. We also useduseURL
ofexpo-linking
(see Expo docs) to parse the WalletConnect URI and pair.goBack
func of the@react-navigation/native
package, but this has the side-effect that if you connect to a desktop browser dApp, the mobile wallet will go to the background after connecting (there's no separate behavior between mobile and desktop browser connections).
iOS
Description
When the request is signed or rejected, the browser app is brought back to focus.EDIT: On iOS 17 this is not the case anymore.Related issues
Related to #95
Related resources
The text was updated successfully, but these errors were encountered: