-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove error analytics #448
Conversation
|
Should we plan a little call to go through this? |
Yes |
51c3374
to
63e15e2
Compare
63e15e2
to
243faca
Compare
@mvaivre as we are preparing to fix the analytics issue, I would like to merge this so I am requesting your review. As the description of the PR says, I went through all places where we call the Posthog API to see where there could be a potential issue in the future. I removed a few API requests in places that I deemed necessary. I also posted a question in Posthog support here: https://posthog.com/questions/how-to-limit-the-amount-of-requests-sent-from-my-app-to-posthog This issue is related: #453 Let me know how you'd like to proceed. |
@mvaivre when you have the time, please check my last comment here 🙏 |
243faca
to
87b4449
Compare
kind ping @mvaivre for my previous comments 🙏 |
4c965c6
to
6c6fef9
Compare
6c6fef9
to
a41c987
Compare
@@ -64,6 +64,7 @@ const WalletSwitchButton = ({ style }: WalletSwitchButtonProps) => { | |||
setNbOfTaps(0) | |||
} | |||
|
|||
// TODO: Shouldn't this be 69? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😨 you're right. I wanted to start counting from -1 to make it less obvious, but apparently I considered this as non vital and made a mistake 🙃
I want to avoid the issue of floading the analytics with errors because of a
useEffect
, like it happened with the GH API rate limits. I went through both our wallets in search of the places we report things to PostHog and removed some. @mvaivre I would like to review them with you and think of a way to ensure that we won't end up with the same problem in the future.