Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit #743

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix audit #743

wants to merge 2 commits into from

Conversation

polarker
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #743 (e55dd4e) into master (d8b20ac) will increase coverage by 0.41%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
+ Coverage   91.51%   91.92%   +0.41%     
==========================================
  Files         355      368      +13     
  Lines       15098    18416    +3318     
  Branches      804      881      +77     
==========================================
+ Hits        13817    16929    +3112     
- Misses       1281     1487     +206     
Impacted Files Coverage Δ
...src/main/scala/org/alephium/wallet/WalletApp.scala 91.89% <75.00%> (-2.05%) ⬇️
...rypto/src/main/scala/org/alephium/crypto/AES.scala 100.00% <100.00%> (ø)
...la/org/alephium/wallet/storage/SecretStorage.scala 98.16% <100.00%> (+0.08%) ⬆️
...in/scala/org/alephium/protocol/vm/ExeFailure.scala 77.77% <0.00%> (-2.23%) ⬇️
...l/src/main/scala/org/alephium/protocol/vm/VM.scala 95.93% <0.00%> (-1.88%) ⬇️
...src/main/scala/org/alephium/io/RocksDBSource.scala 85.50% <0.00%> (-0.86%) ⬇️
.../scala/org/alephium/protocol/vm/ContractPool.scala 95.65% <0.00%> (-0.72%) ⬇️
...in/scala/org/alephium/protocol/vm/WorldState.scala 86.59% <0.00%> (-0.66%) ⬇️
...p/src/main/scala/org/alephium/app/RestServer.scala 100.00% <0.00%> (ø)
...ain/scala/org/alephium/api/EndpointsExamples.scala 100.00% <0.00%> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -30,7 +30,7 @@ object AES {
final case class Encrypted(encrypted: ByteString, salt: ByteString, iv: ByteString)

private val saltByteLength = 64
private val ivByteLength = 64
private val ivByteLength = 12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it means current wallet files won't be compatible anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to check, not sure so far. It's not so urgent, the risk is low.

@polarker polarker closed this Nov 19, 2022
@polarker polarker reopened this Nov 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants