Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

enhance Vietnamese translation #527

Closed
wants to merge 1 commit into from
Closed

Conversation

nit27
Copy link
Contributor

@nit27 nit27 commented Feb 18, 2023

I just made an improvement of Vietnamese translation for next release at commit b1f145a

feel free to discuss :-)

@nop33
Copy link
Member

nop33 commented Feb 20, 2023

@nit27 thank you for this contribution!

I noticed that the master branch of your repository is not rebased on the master branch of our repository. This is probably because it was not updated with the new placeholder translation strings that were added between the first contribution that you made and now. That's why GitHub says that this branch has conflicts. To avoid this situation, before making contributions, always ensure to be up to date with the current master of our repo (either by creating a new feature branch or updating your master branch). Is this helpful, or more confusing for you?

/cc @Sakrecoer, I am tagging you for the language verification procedure that you mentioned.

@nit27
Copy link
Contributor Author

nit27 commented Feb 20, 2023

Oh I am sorry and note it. Thanks for your advice @nop33. Do I need to re-process the procedure to achive the commit?

@nop33
Copy link
Member

nop33 commented Feb 20, 2023

If it's not a big problem for you, it would make it easier for me to integrate it. But if it's too much hassle, I'll do it when I get the time. Thanks!

@nop33 nop33 added the translation A task focused on translation label Feb 23, 2023
@nop33
Copy link
Member

nop33 commented Feb 27, 2023

@nit27 I rebased your branch on top of master and opened a new PR: #536

Closing this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
translation A task focused on translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants