Transaction row details and layout improvements #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaivre
force-pushed
the
transaction-row-details
branch
from
c5380e0
to
655c9f0
Compare
Restricting export to not more than 12 months
Fix last year CSV export
Reorganize footer, add version number
mvaivre
force-pushed
the
transaction-row-details
branch
2 times, most recently
from
c2a0382
to
c3436c2
Compare
mvaivre
changed the title
nop33
reviewed
Mar 15, 2023
There was a problem hiding this comment.
ok, respect, I love this
Have you thought of using the ellipsis component that we have in the desktop wallet, where the ... is added in the middle? Have a look at HashEllipsed. (in branch token-list)
Some missing padding:
Regarding the "?" stuff, I would highly recommend you check out my proposals in the desktop wallet PR, I think they are nice! Looking forward for your input!
mvaivre
force-pushed
the
transaction-row-details
branch
3 times, most recently
from
fa33256
to
7ae9798
Compare
mvaivre
force-pushed
the
transaction-row-details
branch
from
7ae9798
to
a550fe6
Compare
|
Everything has been addressed. Ready for the final review :) |
nop33
reviewed
Mar 20, 2023
nop33
approved these changes
Mar 20, 2023
|
The issue is fixed in the follow-up PR! Thanks for your review, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.