Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize some math glyphs #207

Closed
wants to merge 13 commits into from
Closed

Resize some math glyphs #207

wants to merge 13 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 3, 2018

I'm resizing glyphs in the math font (see #63).

@khaledhosny
Copy link
Contributor

That last commit is modifies too many lines, please rebase it away. Lets see what glyphs are causing the issue and manually fix them. Automatic fixing almost always breaks things.

To find which glyph is causing the issue, open the generated OTF file, run “Find problems” dialog and select “Intersecting Paths” from the Paths tab.

@ghost
Copy link
Author

ghost commented Aug 3, 2018

So I've located the glyphs which cause the issue: they have some overlapping glyphs in them such as /uni226F or /uni2271. How can we fix this ? Edit the otf files and save them as sfd ?

@khaledhosny
Copy link
Contributor

Looks like your new greater glyph has the wrong path direction (did you copy the less glyph and flipped it?). Element → Correct direction should fix it.

@khaledhosny
Copy link
Contributor

Note also that, the mean reason I didn’t do the scaling tell now is that many of these operators are uses as references in other glyphs, and scaling them will break the other glyphs and you will need to check all the glyphs that reference them one by one (I don’t know of any easy way to find all the glyphs that has a given references, you will probably need to script it and assign such glyphs a certain color and review them).

@ghost
Copy link
Author

ghost commented Aug 3, 2018

Yes, this was the problem, thanks ! I plan to add more weight to the math operators just like the \in symbol to better match the font.
I wonder how to make a glyph the mirror of the other: like the < glyph can be edited and the glyph > gets the changes too.

@khaledhosny
Copy link
Contributor

You can use a reference and flip it. Make sure to check “Element → Glyph Info → Mark for Unlink, Remove Overlap before Generating”, as our build scripts check this flag and correct direction automatically as well.

@ghost
Copy link
Author

ghost commented Aug 6, 2018

Thanks ! What do you think of the changes so far ?
I think math symbols shouldn't have rounded corners, especially considering some glyphs get a mixture of both rounded and not rounded corners. The glyphs looks more "clean" without those rounded corners.

@khaledhosny
Copy link
Contributor

Sorry, I’m a bit busy currently, will check it later.

@khaledhosny
Copy link
Contributor

I’m split about the rounded corners, part of me wants to keep it as it can be seen as part of the font overall identity, and part of me finds it a bit weird.

@ghost
Copy link
Author

ghost commented Aug 14, 2018

No problem ! I'm making math fonts to accompany other fonts based on STIX Math's glyphs. In my opinion "geometric" math glyphs should be font independent and tweaked to match the font in size and weight.

@alerque
Copy link
Owner

alerque commented Aug 14, 2018

I'm sorry just an observer here as I rarely use the math font, but can I just say that "font independent" doesn't really make any sense to me? Why purposefully make any part of a font exactly like some other font? Why wouldn't some elements of character come through in math symbols the same way they do in other symbols? I wouldn't expect this at all and indeed would expect some character to come through. I would expect formulas set in Libertinus Math to feel different than ones set in STIX Math or anything else. If you like the glyphs from another font so much why not use that font instead?

@ghost
Copy link
Author

ghost commented Aug 15, 2018

Actually I expect some non alphabetical math glyphs to look in a certain way leaving little room for variation. This is why I think some non alphabetical math glyphs can fit any font provided they are modified to match the weight and style of the font. That’s what I currently do and I’m satisfied with the results.

@khaledhosny
Copy link
Contributor

Sorry for the delay. I generally like the changes, thanks! I think you missed ÷ and few + signs, also the dots on signs like ∓ and ∔. Also signs like ⪯ are now partially resized and look a bit odd.

@ghost
Copy link
Author

ghost commented Oct 7, 2018

Thank you for reviewing my changes. Unfortunately I'm no longer interested in contributing since I've settled in an other font and I have other priorities. Thanks again for your help with this stuff ! Keep it up this is a really cool project.

@khaledhosny
Copy link
Contributor

OK.

@khaledhosny khaledhosny closed this Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants