allow for modifying Alert copy-button behavior #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use nunjucks-templates to modify AlertDetail copy-button behaviour
✅ Deploy Preview for peaceful-beignet-dcf974 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
emillen
added a commit
to emillen/alerta
that referenced
this pull request
Mar 4, 2023
to allow for configuring this web console setting in the backend: alerta/alerta-webui#555
kennhardy
previously approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Looks good. Approved together with alerta/alerta#1814 (dependent)
satterly
pushed a commit
to alerta/alerta
that referenced
this pull request
Mar 7, 2023
* Add CLIPBOARD_TEMPLATE setting to allow for configuring this web console setting in the backend: alerta/alerta-webui#555 * fix lintin errors * Add test for CLIPBOARD_TEMPLATE setting demonstrate that clipboard_template is returned by the api when CLIPBOARD_TEMPLATE is set in the backend --------- Co-authored-by: Kenneth Hardy <kenneth@hardy.se>
satterly
requested changes
Mar 7, 2023
|
What do you say - does this need more work, or are we fine like this? |
|
Can you include a screenshot in the PR description? Thanks. |
|
Actually ignore that. There's probably nothing different. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nunjucks-templates to modify AlertDetail copy-button behavior
Description
Sometimes you want the ability to copy an alert so you can paste into a third party system (slack, email, etc) in human-readable way. This PR allows for setting a nunjuck-template used for formatting the JSON before putting it in the clipboard.
Fixes #522
Changes
clipboard_templatesetting is set, the webui uses its contents as template for the AlertDetail copy buttonclipboard_templateis not set, it defaults to previous behaviorIf you think this is a good idea and merge this, I will add PR's for adding the setting in the backend, and also add it to the docs.
Ex:
Provided following alert-json
{ "text": "this is a major alert", "environment": "prod" }and this template
{ "clipboard_template": "[{{environment | upper}}] Alert!\n{{text}}" }would put the following text in your clipboard