Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set createTime in Prometheus webhook #1158

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Do not set createTime in Prometheus webhook #1158

merged 1 commit into from
Feb 25, 2020

Conversation

satterly
Copy link
Member

Fixes #1132

@coveralls
Copy link

coveralls commented Feb 25, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 74.255% when pulling cb2ec3a on fix-prometheus-webhook-unset-create-time into cd52182 on master.

@satterly satterly force-pushed the fix-prometheus-webhook-unset-create-time branch from b605c5b to cb2ec3a Compare February 25, 2020 15:00
@satterly satterly merged commit 1011f26 into master Feb 25, 2020
@satterly satterly mentioned this pull request Feb 25, 2020
Merged
@satterly satterly mentioned this pull request Jun 10, 2020
Closed
saivarunr pushed a commit to rudderlabs/alerta that referenced this pull request Nov 27, 2021
@satterly
Do not set createTime in Prometheus webhook (alerta#1158)
23e056a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blackout timerange check uses create time, not a current one
2 participants
@satterly @coveralls