fix(auth): HMAC was falling thru to catchall if auth required #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satterly
force-pushed
the
fix-hmac-if-auth-required
branch
from
580d37e
to
8154031
Compare
satterly
force-pushed
the
fix-hmac-if-auth-required
branch
from
31a9064
to
f013a73
Compare
saivarunr
pushed a commit
to rudderlabs/alerta
that referenced
this pull request
Nov 27, 2021
…#1470) * fix(auth): HMAC was falling thru to catchall if auth required * fix(tests): fix forwarder test with auth enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though a request may have been successfully authenticated using HMAC if
AUTH_REQUIREDwas set toTrueit would always fail with a 401 error.