Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename wheel to alertaclient #199

Closed
wants to merge 1 commit into from

Conversation

fhoehle
Copy link

@fhoehle fhoehle commented Jan 17, 2020

This PR renames the python package wheel from alerta to alertaclient
At the moment by running: python setup.py bdist_wheel a wheel is created dist/alerta-7.4.0-py2.py3-none-any.whl

This PR will change this output to dist/alertaclient-7.4.0-py2.py3-none-any.whl and python package name is in sync with the wheel name, i.e. import alertaclient and pip install alertaclient.

@fhoehle fhoehle force-pushed the rename_wheel_to_alertaclient branch from d8e09de to 617e483 Compare January 17, 2020 16:23
@satterly
Copy link
Member

Won't this move the package from https://pypi.org/project/alerta/ to https://pypi.org/project/alertaclient/ ?

@fhoehle
Copy link
Author

fhoehle commented Jan 17, 2020

Yes, and afterwards both namens are in sync, similar to standard python packages.

@satterly
Copy link
Member

I don't want the PyPi package name to change. That would break loads of stuff and the fact that the name of the package is different to the import statement is not important. There are lots of packages where this isn't the case. Thanks anyway.

@satterly satterly closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants