validation: handle ActiveModel::UnknownAttributeError

alessandro-fazzi · Aug 12, 2024 · 96b6164 · 96b6164
1 parent fac20d2
commit 96b6164
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/i_do_not_need_interactor/contract/active_model.rb b/lib/i_do_not_need_interactor/contract/active_model.rb
@@ -8,7 +8,9 @@ module ActiveModel # rubocop:disable Style/Documentation
       def self.included(descendant) # rubocop:disable Metrics/MethodLength
         class << descendant
           def contract(&block)
+            caller = self
             @contract = Class.new do
+              set_temporary_name("#{caller.inspect.downcase}::contract")
               include ::ActiveModel::API
               include ::ActiveModel::Attributes
               include ::ActiveModel::Validations
@@ -24,7 +26,7 @@ def self.model_name
 
       def validate(ctx)
         self.class.instance_variable_get(:@contract).new(**ctx).validate!
-      rescue ::ActiveModel::ValidationError => e
+      rescue ::ActiveModel::ValidationError, ::ActiveModel::UnknownAttributeError => e
         ctx.errors << e.message
       end
     end

diff --git a/test/test_i_do_not_need_interactor.rb b/test/test_i_do_not_need_interactor.rb
@@ -134,6 +134,12 @@ def test_contract_active_model_integration
     assert_equal ["Validation failed: Test can't be blank"], outcome.errors
   end
 
+  def test_contract_active_model_integration_with_unknown_attribute
+    outcome = InteractorWithActiveModelContract.call(foo: 1)
+
+    assert_equal ["unknown attribute 'foo' for interactorwithactivemodelcontract::contract."], outcome.errors
+  end
+
   def test_contract_dry_validation_integration
     outcome = InteractorWithDryValidationContract.call