Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Maybe Monad API interface #2

Merged
merged 7 commits into from
Apr 20, 2019
Merged

Change Maybe Monad API interface #2

merged 7 commits into from
Apr 20, 2019

Conversation

moba1
Copy link
Collaborator

@moba1 moba1 commented Apr 20, 2019 •
edited
Loading

Issue: #1
Maybe monad should be close to Haskell or Scala's API

@moba1 moba1 changed the title Change Maybe Monad API interface #1 Change Maybe Monad API interface Apr 20, 2019
@moba1 moba1 requested a review from alex-lairan April 20, 2019 13:52
alex-lairan
alex-lairan approved these changes Apr 20, 2019
View reviewed changes
Copy link
Owner

@alex-lairan alex-lairan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it was a legacy from dry-rb ;)

src/monads/maybe.cr Outdated Show resolved Hide resolved
alex-lairan
alex-lairan requested changes Apr 20, 2019
View reviewed changes
Copy link
Owner

@alex-lairan alex-lairan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing, I think they not compile now.

@moba1
Copy link
Collaborator Author

moba1 commented Apr 20, 2019

fix tests

alex-lairan
alex-lairan approved these changes Apr 20, 2019
View reviewed changes
Copy link
Owner

@alex-lairan alex-lairan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :)

I can't test in local for the moment, but everything looks great.

I think it will be easier to use the Maybe monad (I had some problems with the template missing on some other projects)

LGTM :)

@moba1 moba1 merged commit 54f9b97 into master Apr 20, 2019
@moba1 moba1 deleted the fix/maybe-monad-api branch April 20, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-lairan alex-lairan alex-lairan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moba1 @alex-lairan