Skip to content

Commit

Permalink
Fixed #21438: makemigrations now detects ManyToManyFields
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewgodwin committed Nov 27, 2013
1 parent 19b34fb commit 5e63977
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions django/db/migrations/state.py
Expand Up @@ -100,6 +100,10 @@ def from_model(cls, model):
name, path, args, kwargs = field.deconstruct()
field_class = import_by_path(path)
fields.append((name, field_class(*args, **kwargs)))
for field in model._meta.local_many_to_many:
name, path, args, kwargs = field.deconstruct()
field_class = import_by_path(path)
fields.append((name, field_class(*args, **kwargs)))
# Extract the options
options = {}
for name in DEFAULT_NAMES:
Expand Down
4 changes: 3 additions & 1 deletion tests/migrations/test_state.py
Expand Up @@ -36,6 +36,7 @@ class Meta:
class Book(models.Model):
title = models.CharField(max_length=1000)
author = models.ForeignKey(Author)
contributors = models.ManyToManyField(Author)

class Meta:
app_label = "migrations"
Expand All @@ -59,9 +60,10 @@ class Meta:

self.assertEqual(book_state.app_label, "migrations")
self.assertEqual(book_state.name, "Book")
self.assertEqual([x for x, y in book_state.fields], ["id", "title", "author"])
self.assertEqual([x for x, y in book_state.fields], ["id", "title", "author", "contributors"])
self.assertEqual(book_state.fields[1][1].max_length, 1000)
self.assertEqual(book_state.fields[2][1].null, False)
self.assertEqual(book_state.fields[3][1].__class__.__name__, "ManyToManyField")
self.assertEqual(book_state.options, {"verbose_name": "tome", "db_table": "test_tome"})
self.assertEqual(book_state.bases, (models.Model, ))

Expand Down

0 comments on commit 5e63977

Please sign in to comment.