Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add id so I can link directly to a row #221

Merged
merged 1 commit into from Nov 6, 2020
Merged

add id so I can link directly to a row #221

merged 1 commit into from Nov 6, 2020

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Nov 6, 2020 •
edited

Motivation
Changes
  • Ensured that you have rebased your branch with this repo's latest master branch.
  • Ensured that relevant issues are linked, if this PR resolves any outstanding.
  • Added a screenshot for all UI changes (you can drag the file into this edit box and it will be uploaded).
  • Ensured that changes to auto-generated files have not been committed; in particular, *.html, *.csv and *.json files.

bojanrajkovic
bojanrajkovic requested changes Nov 6, 2020
View reviewed changes
Copy link
Collaborator

@bojanrajkovic bojanrajkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won’t the timestamp be inconsistent, so the link would keep changing all the time?

@graingert
Copy link
Contributor Author

@bojanrajkovic isn't the timestamp historical?

@bojanrajkovic
Copy link
Collaborator

No, it’s the scrape timestamp for the current run. It would change every run, AFAICT.

@graingert
Copy link
Contributor Author

@bojanrajkovic once a row is added, it's not updated:
8b0933f#diff-46d4fb93617cbbf767d42a55d3729dbd6f38900c2b3dfecb826bc657dc4e3be0R851

@bojanrajkovic
Copy link
Collaborator

Oh god I'm an idiot. This whole time I was confusing rows w/ the state header. That's what I get for reviewing PRs while still in bed.

@bojanrajkovic bojanrajkovic merged commit a08fd19 into alex:master Nov 6, 2020
@graingert graingert deleted the patch-1 branch November 6, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojanrajkovic bojanrajkovic bojanrajkovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graingert @bojanrajkovic