-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-leaflet-draw updated to v3 react-leaflet 3.0.0 #90
react-leaflet-draw updated to v3 react-leaflet 3.0.0 #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things I notice:
Stray console.log left behind and i don't think the library author will be happy that the quotes all got changed from single to double. Run eslint fix to take care of this so that it conforms to the linter setup he has defined.
To be clear: not just the double quotes. I am guessing you ran this through a tool like prettier. It creates a lot of 'noise' in the changes. If you do use a tool like prettier be sure to also eslint fix. Doing so will greatly increase the chance that the repo owner will accept your PR. Thanks for your hard work. Much appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove extra logs or add useful message as it is done with already existing logs
Yes, please I will take care of this. Give me some time and I will respond with all the new changes |
I removed all the double quotes |
Please merge my branch