Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added locale selector to test page #74

Merged
merged 4 commits into from Feb 7, 2017

Conversation

Projects
None yet
2 participants
@siedi
Copy link
Contributor

commented Feb 7, 2017

Since Alexa supports multiple languages it is sending the locale in the request. Added this to the test page so alexa-app based skills can test it easily.

@dblock

This comment has been minimized.

Copy link
Collaborator

commented Feb 7, 2017

Thanks! Could you please update CHANGELOG as the bot asks?

I'd love some tests for the simulator. Maybe you can help with that too?

@siedi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2017

Updated the Changelog, btw, should fix #12
Regarding the simulator tests, I'm sorry, frontend is not my area. API / backend would be ok :-)

siedi added some commits Feb 7, 2017

@dblock dblock merged commit 985e071 into alexa-js:master Feb 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.513%
Details
@dblock

This comment has been minimized.

Copy link
Collaborator

commented Feb 7, 2017

Thanks, merged.

@dblock dblock referenced this pull request Feb 7, 2017

Closed

Add I18n support #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.