feat: Add TypeScript Generics on the getSessionAttributes Method (#554)

alexa · Jun 27, 2019 · 0824495 · 0824495
1 parent 89173bc
commit 0824495
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ask-sdk-core/lib/attributes/AttributesManager.ts b/ask-sdk-core/lib/attributes/AttributesManager.ts
@@ -24,7 +24,7 @@ export interface AttributesManager {
      * Provides session attributes extracted from request envelope.
      * @returns {Object.<string, any>}
      */
-    getSessionAttributes() : {[key : string] : any};
+    getSessionAttributes<T = {[key : string] : any}>() : T;
     /**
      * Provides persistent attributes retrieved and cached from persistence adapter.
      * @returns {Promise<Object.<string, any>>}

diff --git a/ask-sdk-core/lib/attributes/AttributesManagerFactory.ts b/ask-sdk-core/lib/attributes/AttributesManagerFactory.ts
@@ -44,14 +44,14 @@ export class AttributesManagerFactory {
             getRequestAttributes() : {[key : string] : any} {
                 return thisRequestAttributes;
             },
-            getSessionAttributes() : {[key : string] : any} {
+            getSessionAttributes<T = {[key : string] : any}>() : T {
                 if (!options.requestEnvelope.session) {
                     throw createAskSdkError(
                         'AttributesManager',
                         'Cannot get SessionAttributes from out of session request!');
                 }
 
-                return thisSessionAttributes;
+                return thisSessionAttributes as T;
             },
             async getPersistentAttributes() : Promise<{[key : string] : any}> {
                 if (!options.persistenceAdapter) {