fix: change the getSlotValue util function to return null when slot i…

…s not present (#573)
alexa · Jul 16, 2019 · 1321407 · 1321407
1 parent 30e5560
commit 1321407
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/ask-sdk-core/lib/util/RequestEnvelopeUtils.ts b/ask-sdk-core/lib/util/RequestEnvelopeUtils.ts
@@ -175,7 +175,7 @@ export function getSlot(requestEnvelope : RequestEnvelope, slotName : string) :
  * Returns the value from the given {@link Slot} in the request.
  *
  * This method attempts to retrieve the requested {@link Slot}'s value from the incoming request. If the slot does not
- * exist in the request, an Error will be raised.
+ * exist in the request, a null will be returned.
  *
  * @param {RequestEnvelope} requestEnvelope
  * @param {string} slotName
@@ -188,10 +188,7 @@ export function getSlotValue(requestEnvelope : RequestEnvelope, slotName : strin
             return slot.value;
         }
 
-        throw createAskSdkError(
-            'RequestEnvelopeUtils',
-            `Cannot find slot with name ${slotName}.`,
-        );
+        return null;
     }
 
     throw createAskSdkError(

diff --git a/ask-sdk-core/tst/util/RequestEnvelopeUtil.spec.ts b/ask-sdk-core/tst/util/RequestEnvelopeUtil.spec.ts
@@ -151,9 +151,7 @@ describe('RequestEnvelopeUtils', () => {
     });
 
     it('should throw an error if trying to get slot value of non existent slot', () => {
-        expect(() => {
-            getSlotValue(intentRequestEnvelope, 'non-existentSlot');
-        }).to.throw(`Cannot find slot with name non-existentSlot.`);
+        expect(getSlotValue(intentRequestEnvelope, 'non-existentSlot')).eq(null);
     });
 
     it('should throw an error if trying to get slot value of non-intent request', () => {