fix: remove response factory auto escape xml character behavior.

Hot fix: this commit removes the auto-escape xml character behavior that might cause valid ssml tags to be escaped as well. Keeping the util function for developer to opt-in to use.
alexa · Mar 8, 2019 · 31ce953 · 31ce953
1 parent 5923afa
commit 31ce953
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 23 deletions.
diff --git a/ask-sdk-core/lib/response/ResponseFactory.ts b/ask-sdk-core/lib/response/ResponseFactory.ts
@@ -20,7 +20,6 @@ import {
     Response,
     ui,
 } from 'ask-sdk-model';
-import { escapeXmlCharacters } from '../util/SsmlUtils';
 import { ResponseBuilder } from './ResponseBuilder';
 import Stream = interfaces.audioplayer.Stream;
 import AudioItem = interfaces.audioplayer.AudioItem;
@@ -80,7 +79,7 @@ export class ResponseFactory {
                 response.outputSpeech = {
                     type : 'SSML',
                     ssml : '<speak>'
-                           + escapeXmlCharacters(trimOutputSpeech(speechOutput))
+                           + trimOutputSpeech(speechOutput)
                            + '</speak>',
                     playBehavior,
                 };
@@ -96,7 +95,7 @@ export class ResponseFactory {
                     outputSpeech : {
                         type : 'SSML',
                         ssml : '<speak>'
-                               + escapeXmlCharacters(trimOutputSpeech(repromptSpeechOutput))
+                               + trimOutputSpeech(repromptSpeechOutput)
                                + '</speak>',
                         playBehavior,
                     },

diff --git a/ask-sdk-core/tst/response/ResponseFactory.spec.ts b/ask-sdk-core/tst/response/ResponseFactory.spec.ts
@@ -118,26 +118,6 @@ describe('ResponseFactory', () => {
         expect(responseBuilder.reprompt(speechOutput, 'ENQUEUE').getResponse()).to.deep.equal(expectResponse);
     });
 
-    it('should auto-escape invalid ssml character', () => {
-        const responseBuilder : ResponseBuilder = ResponseFactory.init();
-        const speechOutput = 'Hello World & Happy New Year!';
-        const expectResponse = {
-            outputSpeech: {
-                ssml: '<speak>' + `Hello World &amp; Happy New Year!` + '</speak>',
-                type: 'SSML',
-            },
-            reprompt : {
-                outputSpeech : {
-                    ssml: '<speak>' + `Hello World &amp; Happy New Year!` + '</speak>',
-                    type: 'SSML',
-                },
-            },
-            shouldEndSession : false,
-        };
-
-        expect(responseBuilder.speak(speechOutput).reprompt(speechOutput).getResponse()).to.deep.equal(expectResponse);
-    });
-
     it('should build response with simple card', () => {
         const responseBuilder : ResponseBuilder = ResponseFactory.init();
         const cardTitle = 'Card Title';