fix: export UserAgentManager from core (#659)

Co-authored-by: Shen Chen <shench@amazon.com>
alexa · Oct 9, 2020 · b99d08d · b99d08d
1 parent c1d833e
commit b99d08d
Show file tree

Hide file tree

Showing 8 changed files with 32 additions and 15 deletions.
diff --git a/ask-sdk-core/CHANGELOG.md b/ask-sdk-core/CHANGELOG.md
@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [2.10.1](https://github.com/alexa/alexa-skills-kit-sdk-for-nodejs/compare/v2.9.0...v2.10.0) (2020-10-09)
+
+
+### Features
+
+* export UserAgentManager class in SDK core
+
+
+
+
+
 # [2.10.0](https://github.com/alexa/alexa-skills-kit-sdk-for-nodejs/compare/v2.9.0...v2.10.0) (2020-10-08)
 
 

diff --git a/ask-sdk-core/lib/index.ts b/ask-sdk-core/lib/index.ts
@@ -68,5 +68,6 @@ export {
 
 export {
     createAskSdkError,
-    createAskSdkUserAgent
+    createAskSdkUserAgent,
+    UserAgentManager
 } from 'ask-sdk-runtime';
diff --git a/ask-sdk-core/package.json b/ask-sdk-core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ask-sdk-core",
-  "version": "2.10.0",
+  "version": "2.10.1",
   "description": "Core package for Alexa Skills Kit SDK",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -29,7 +29,7 @@
     "SDK"
   ],
   "dependencies": {
-    "ask-sdk-runtime": "^2.10.0"
+    "ask-sdk-runtime": "^2.10.1"
   },
   "peerDependencies": {
     "ask-sdk-model": "^1.29.0"

diff --git a/ask-sdk-core/tst/skill/CustomSkill.spec.ts b/ask-sdk-core/tst/skill/CustomSkill.spec.ts
@@ -22,7 +22,8 @@ import { MockAlwaysFalseRequestHandler } from '../mocks/request/MockAlwaysFalseR
 import { MockAlwaysTrueRequestHandler } from '../mocks/request/MockAlwaysTrueRequestHandler';
 
 beforeEach(function() {
-    UserAgentManager.clear();
+    UserAgentManager['components'].clear();
+    UserAgentManager['userAgent'] = '';
 });
 
 describe('CustomSkill', () => {

diff --git a/ask-sdk-runtime/CHANGELOG.md b/ask-sdk-runtime/CHANGELOG.md
@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [2.10.1](https://github.com/alexa/alexa-skills-kit-sdk-for-nodejs/compare/v2.9.0...v2.10.0) (2020-10-09)
+
+
+### Bug Fixes
+
+* remove the clear function in UserAgentManager
+
+
+
+
+
+
 # [2.10.0](https://github.com/alexa/alexa-skills-kit-sdk-for-nodejs/compare/v2.9.0...v2.10.0) (2020-10-08)
 
 

diff --git a/ask-sdk-runtime/lib/util/UserAgentManager.ts b/ask-sdk-runtime/lib/util/UserAgentManager.ts
@@ -42,13 +42,4 @@ export class UserAgentManager {
             this.userAgent = updatedUserAgent;
         }
     }
-
-    /**
-     * Clears any existing components from the user agent and resets it to empty.
-     */
-    static clear() {
-        this.components.clear();
-        this.userAgent = '';
-    }
-
 }
diff --git a/ask-sdk-runtime/package.json b/ask-sdk-runtime/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ask-sdk-runtime",
-  "version": "2.10.0",
+  "version": "2.10.1",
   "description": "Base runtime package for Alexa Skills Kit SDK",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/ask-sdk-runtime/tst/util/UserAgentManager.spec.ts b/ask-sdk-runtime/tst/util/UserAgentManager.spec.ts
@@ -33,7 +33,8 @@ describe('UserAgentManager', () => {
     it('should clear components', () => {
         UserAgentManager.registerComponent('foo');
         UserAgentManager.registerComponent('bar');
-        UserAgentManager.clear();
+        UserAgentManager['components'].clear();
+        UserAgentManager['userAgent'] = '';
         expect(UserAgentManager.getUserAgent()).equal('');
     });
 });