Skip to content

Commit

Permalink
Introducing Runtime layer (#41)
Browse files Browse the repository at this point in the history
This commit contains the following changes:
- Add ask-sdk-runtime package
- Refactored following abstract and implemented classes from ask-sdk-core to ask-sdk-runtime, since they are generic
        - AbstractHandlerAdapter
        - HandlerAdapter (renamed to GenericHandlerAdapter)
        - AbstractRequestHandlerChain
        - RequestHandlerChain (renamed to GenericRequestHandlerChain)
        - AbstractRequestMapper
        - RequestMapper (renamed to GenericRequestMapper)
        - AbstractRequestDispatcher
        - RequestDispatcher (renamed to GenericRequestDispatcher)
        - AbstractExceptionMapper
        - ExceptionMapper (renamed to GenericExceptionMapper)
        - Dispatch, Skill Builder exceptions
        - User Agent utility
- Added AbstractSkillBuilder, AbstractSkill, RuntimeConfiguration classes
- Refactored dependencies as needed
- Refactored tests as needed
  • Loading branch information
nikhilym committed Oct 29, 2018
1 parent ed0d650 commit c9ce2e7
Show file tree
Hide file tree
Showing 46 changed files with 2,841 additions and 1,720 deletions.
3 changes: 2 additions & 1 deletion ask-sdk-core/.coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ include =
ask_sdk_core/*
exclude_lines =
if typing.TYPE_CHECKING:
pass
pass
raise NotImplementedError
3 changes: 2 additions & 1 deletion ask-sdk-core/ask_sdk_core/__version__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,6 @@
__author_email__ = 'ask-sdk-dynamic@amazon.com'
__license__ = 'Apache 2.0'
__keywords__ = ['ASK SDK', 'Alexa Skills Kit', 'Alexa', 'Core']
__install_requires__ = ["six", "requests", "python_dateutil", "ask-sdk-model"]
__install_requires__ = ["six", "requests", "python_dateutil",
"ask-sdk-model", "ask-sdk-runtime"]

224 changes: 0 additions & 224 deletions ask-sdk-core/ask_sdk_core/dispatch.py

This file was deleted.

5 changes: 2 additions & 3 deletions ask-sdk-core/ask_sdk_core/dispatch_components/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

from .request_components import (
AbstractRequestHandler, AbstractRequestInterceptor,
AbstractResponseInterceptor, HandlerAdapter, RequestMapper,
RequestHandlerChain)
AbstractResponseInterceptor)
from .exception_components import (
AbstractExceptionHandler, ExceptionMapper)
AbstractExceptionHandler)
Loading

0 comments on commit c9ce2e7

Please sign in to comment.