Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing Runtime layer #41

Merged
merged 4 commits into from
Oct 29, 2018
Merged

Introducing Runtime layer #41

merged 4 commits into from
Oct 29, 2018

Conversation

nikhilym
Copy link
Contributor

Abstracts away core SDK request routing and handling components into a generic runtime layer.

Testing

Tested against existing skills to confirm backwards compatibility

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nikhilym
Provide json data to service client only if present
9bd549c
@nikhilym
Scope requests to install internal dependencies for doc building
11cd99d
@nikhilym
SDK Structure update
c19d320 
This commit contains the following changes:
- Add ask-sdk-runtime package
- Refactored following abstract and implemented classes from ask-sdk-core to ask-sdk-runtime, since they are generic
        - AbstractHandlerAdapter (renamed to AbstractHandlerAdapter)
        - HandlerAdapter (renamed to GenericHandlerAdapter)
        - AbstractRequestHandlerChain
        - RequestHandlerChain (renamed to GenericRequestHandlerChain)
        - AbstractRequestMapper
        - RequestMapper (renamed to GenericRequestMapper)
        - AbstractRequestDispatcher
        - RequestDispatcher (renamed to GenericRequestDispatcher)
        - AbstractExceptionMapper
        - ExceptionMapper (renamed to GenericExceptionMapper)
        - Dispatch, Skill Builder exceptions
        - User Agent utility
- Added AbstractSkillBuilder, AbstractSkill, RuntimeConfiguration classes
- Refactored dependencies as needed
- Refactored tests as needed
@nikhilym nikhilym added the enhancement New feature or request label Oct 26, 2018
@nikhilym nikhilym merged commit c9ce2e7 into alexa:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedloj breedloj breedloj approved these changes

@tianrenz tianrenz tianrenz approved these changes

@Chris-Liao Chris-Liao Awaiting requested review from Chris-Liao

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikhilym @breedloj @tianrenz