Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dependencies for python versions #50

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Refactor dependencies for python versions #50

merged 1 commit into from
Nov 26, 2018

Conversation

nikhilym
Copy link
Contributor

Description

This commit makes the following changes:

  • Set 'typing' package to be installed only on Python 2.7. This fixes the import issue raised in Python 3.7, on using the 'typing 3.6' module, as mentioned in issue Callable has no attribute __abc_registry #49.
  • Remove dependencies on enum34 and typing from extra_requires fields in setup files, since these are installed as dependencies in ask-sdk-model package.
  • Set the install_requires dependencies to follow the same version as mentioned in requirements.txt in all ask-sdk* packages.

Motivation and Context

Fixes #49 , making the SDK compatible with Python 3.7

Testing

Ran tox and tested with couple of sample skills on Python 3.6, Python 3.7

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit makes the following changes:

 - Set 'typing' package to be installed only on Python 2.7. This fixes the import issue raised in Python 3.7, on using the 'typing 3.6' module, as mentioned in issue #49.
 - Remove dependencies on enum34 and typing from extra_requires fields in setup files, since these are installed as dependencies in ask-sdk-model package.
 - Set the install_requires dependencies to follow the same version as mentioned in requirements.txt in all ask-sdk* packages.
@nikhilym nikhilym merged commit 6cac5df into alexa:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callable has no attribute __abc_registry
4 participants