ERROR WHILE BUILD SDK

[patadia]

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.

Briefly summarize your issue:

from a guide for macOs quickstart in step Build SDK I got following error

p.p1 {margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px 'Helvetica Neue'}

jays-MacBook-Air:sdk-build jaysanjay$ make SampleApp -j2 >>jay.txt

In file included from /Users/jaysanjay/sdk-folder/sdk-source/avs-device-sdk/CapabilityAgents/DoNotDisturb/src/DoNotDisturbCapabilityAgent.cpp:16:

In file included from /Users/jaysanjay/sdk-folder/sdk-source/avs-device-sdk/ThirdParty/rapidjson/rapidjson-1.1.0/include/rapidjson/error/en.h:18:

In file included from /Users/jaysanjay/sdk-folder/sdk-source/avs-device-sdk/ThirdParty/rapidjson/rapidjson-1.1.0/include/rapidjson/error/../error/error.h:18:

In file included from /Users/jaysanjay/sdk-folder/sdk-source/avs-device-sdk/ThirdParty/rapidjson/rapidjson-1.1.0/include/rapidjson/error/../internal/../rapidjson.h:144:

In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/string:477:

In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/string_view:176:

In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/__string:56:

In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/algorithm:643:

/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2285:5: error: delete called on non-final

  'alexaClientSDK::settings::Setting<bool>' that has virtual functions but non-virtual destructor

  [-Werror,-Wdelete-non-virtual-dtor]

delete __ptr;

^

/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2598:7: note: in instantiation of member function

  'std::__1::default_delete<alexaClientSDK::settings::Setting<bool> >::operator()' requested here

  __ptr_.second()(__tmp);

  ^

/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2552:19: note: in instantiation of member function

  'std::__1::unique_ptr<alexaClientSDK::settings::Setting<bool>, std::__1::default_delete<alexaClientSDK::settings::Setting<bool> >

  >::reset' requested here

~unique_ptr() { reset(); }

              ^

/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:4013:21: note: in instantiation of member function

  'std::__1::unique_ptr<alexaClientSDK::settings::Setting<bool>, std::__1::default_delete<alexaClientSDK::settings::Setting<bool> >

  >::~unique_ptr' requested here

unique_ptr<_Yp> __hold(__p);

                ^

/Users/jaysanjay/sdk-folder/sdk-source/avs-device-sdk/Settings/include/Settings/Setting.h:137:9: note: in instantiation of function

  template specialization 'std::__1::shared_ptr<alexaClientSDK::settings::Setting<bool>

  >::shared_ptr<alexaClientSDK::settings::Setting<bool> >' requested here

    std::shared_ptr<Setting<ValueT>>(new Setting(defaultValue, applyValueFn, std::move(settingProtocol)));

    ^

/Users/jaysanjay/sdk-folder/sdk-source/avs-device-sdk/CapabilityAgents/DoNotDisturb/src/DoNotDisturbCapabilityAgent.cpp:143:49: note:

  in instantiation of member function 'alexaClientSDK::settings::Setting<bool>::create' requested here

m_dndModeSetting = settings::Setting<bool>::create(false, std::move(protocol));

                                            ^

1 error generated.

make[3]: *** [CapabilityAgents/DoNotDisturb/src/CMakeFiles/DoNotDisturbCA.dir/DoNotDisturbCapabilityAgent.cpp.o] Error 1

make[2]: *** [CapabilityAgents/DoNotDisturb/src/CMakeFiles/DoNotDisturbCA.dir/all] Error 2

make[1]: *** [SampleApp/src/CMakeFiles/SampleApp.dir/rule] Error 2

make: *** [SampleApp] Error 2

jays-MacBook-Air:sdk-build jaysanjay$

What is the expected behavior?

What behavior are you observing?

Provide the steps to reproduce the issue, if applicable:

from MacOS QUICKSTART GUIDE

Tell us about your environment:

What version of the AVS Device SDK are you using?

  1.10

Tell us what hardware you're using:

• [-] Desktop / Laptop
• Raspberry Pi
• Other - tell us more:

Tell us about your OS (Type & version):

• Linux
• [-] MacOS
• Raspbian Stretch
• Raspbian Jessy
• Other - tell us more:

[scotthea-amazon]

Hello patadia,

Thank you for bringing this to our attention!

From the error messages, it looks like this might be addressed by adding a default virtual destructor to SettingInterface.

We did not run across this in our testing on MacOS. I wonder if your compiler is just configured differently. Can you attach a copy of CMakeFiles/[your CMake's version]/CMakeCXXCompiler.cmake
from your build folder so that we might better understand this problem?

Best regards,
-SWH

[frivas]

Hello @scotthea-amazon, I am also having the same error, Please find enclosed the CMakeCXXCompiler.cmake. I am using v1.11 of the SDK.

CMakeCXXCompiler.cmake.zip

What thing I have noticed is that the origin of the error is slightly different

In file included from /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__string:56:
In file included from /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:643:
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2285:5: error: delete called on non-final
      'alexaClientSDK::settings::Setting<bool>' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete __ptr;
    ^
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2598:7: note: in instantiation of member function
      'std::__1::default_delete<alexaClientSDK::settings::Setting<bool> >::operator()' requested here
      __ptr_.second()(__tmp);
      ^
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2552:19: note: in instantiation of member
      function 'std::__1::unique_ptr<alexaClientSDK::settings::Setting<bool>, std::__1::default_delete<alexaClientSDK::settings::Setting<bool> > >::reset'
      requested here
  ~unique_ptr() { reset(); }
                  ^
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4013:21: note: in instantiation of member
      function
      'std::__1::unique_ptr<alexaClientSDK::settings::Setting<bool>, std::__1::default_delete<alexaClientSDK::settings::Setting<bool> > >::~unique_ptr'
      requested here
    unique_ptr<_Yp> __hold(__p);
                    ^
/Users/fran/Downloads/ExplorationProjects/AVS_macOS/sdk-source/avs-device-sdk/Settings/include/Settings/Setting.h:137:9: note: in instantiation of function
      template specialization 'std::__1::shared_ptr<alexaClientSDK::settings::Setting<bool> >::shared_ptr<alexaClientSDK::settings::Setting<bool> >' requested
      here
        std::shared_ptr<Setting<ValueT>>(new Setting(defaultValue, applyValueFn, std::move(settingProtocol)));
        ^
/Users/fran/Downloads/ExplorationProjects/AVS_macOS/sdk-source/avs-device-sdk/CapabilityAgents/DoNotDisturb/src/DoNotDisturbCapabilityAgent.cpp:143:49: note: 
      in instantiation of member function 'alexaClientSDK::settings::Setting<bool>::create' requested here
    m_dndModeSetting = settings::Setting<bool>::create(false, std::move(protocol));
                                                ^
1 error generated.
make[3]: *** [CapabilityAgents/DoNotDisturb/src/CMakeFiles/DoNotDisturbCA.dir/DoNotDisturbCapabilityAgent.cpp.o] Error 1
make[2]: *** [CapabilityAgents/DoNotDisturb/src/CMakeFiles/DoNotDisturbCA.dir/all] Error 2
make[1]: *** [SampleApp/src/CMakeFiles/SampleApp.dir/rule] Error 2
make: *** [SampleApp] Error 2

Just checked #880 not sure if it is related, just in case, below the GCC and Clang version my system is currently using:

➜  sdk-build gcc --version
Configured with: --prefix=/Applications/Xcode-beta.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/c++/4.2.1
Apple LLVM version 10.0.0 (clang-1000.11.45.5)
Target: x86_64-apple-darwin18.2.0
Thread model: posix
InstalledDir: /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

➜  sdk-build clang -v      
Apple LLVM version 10.0.0 (clang-1000.11.45.5)
Target: x86_64-apple-darwin18.2.0
Thread model: posix
InstalledDir: /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Thank you very much in advanced.

[frivas]

Hello @scotthea-amazon,

Just an update.

I have added the default virtual destructor to the SettingInterface.h like so:

virtual ~SettingInterface() = default;

The build process almost finishes correctly.

There is an error at the end

[100%] Building CXX object SampleApp/src/CMakeFiles/SampleApp.dir/main.cpp.o
[100%] Building CXX object SampleApp/src/CMakeFiles/SampleApp.dir/PortAudioMicrophoneWrapper.cpp.o
make[2]: *** No rule to make target `/Users/fran/Downloads/ExplorationProjects/AVS_macOS/sdk-source/avs-device-sdk/third-party/portaudio/lib/.libs/libportaudio.a', needed by `SampleApp/src/SampleApp'.  Stop.
make[1]: *** [SampleApp/src/CMakeFiles/SampleApp.dir/all] Error 2
make: *** [all] Error 2

Still investigating what is going on.

[UPDATE]: The lib directory I specified was wrong, now it is fixed and it has build the app correctly.

Thank you very much again.

[visayamv]

Hi @frivas , thanks for the update. We will fix the missing virtual destructor in the code.

[jbfitb]

@visayamv Is there a timeline for that? It's been over two months since the issue was reported.

[kclchan]

Thanks for opening this issue. It has been fixed in our v1.12 release. Thanks!