Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytview update #2: mdfind & graceful exit #130

Merged
merged 3 commits into from
Oct 29, 2017

Conversation

JayBrown
Copy link
Contributor

(1) mdfind stuff now in the else statement
(2) added integer checks for $titlenumber + exit 0

Pull Request Label:

  • Bug
  • New feature
  • Enhancement
  • New component
  • Typo

Pull Request Checklist:


(1) mdfind stuff now in the else statement
(2) added integer checks for $titlenumber + exit 0
one `fi` missing
@JayBrown
Copy link
Contributor Author

(Still some weird stuff with the tabs.)

sed substitution for double quotes
@alexanderepstein
Copy link
Owner

Looks good at first glance, I will have to test this on my own mac either tonight or sometime this weekend, I wouldn't worry to much about the fact that the formatting is off for whatever reason, I will just push a commit to your repository formatting the code. Sorry I can't be faster with merging this but the changes are definitely larger so I want to make sure I can test it, and I am pretty busy with schoolwork at the moment but I will find the time. 👍

@JayBrown
Copy link
Contributor Author

I've already saved my version to the ytview in my $PATH, so there is definitely no rush. And yeah, better safe than sorry, though it seems to be working here.

@alexanderepstein
Copy link
Owner

Sorry this taking longer than expected to test, have been very lately will try to get to it asap 👍

@alexanderepstein
Copy link
Owner

Sorry this took me so long to test but it seems to work well! Thanks again for your contribution 🎉

@alexanderepstein alexanderepstein merged commit 9b850be into alexanderepstein:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants