This repository has been archived by the owner on Jul 30, 2020. It is now read-only.
Issue with model.get not a function #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had an issue with activeRoute calling model.get() if model is present. For a model that is an Ember.RSVP.hash model, for example, this was failing. I added a line here to check if model has the get() function.
|
Thanks for your contribution, this solution will suffice for now until I can come up with a better approach to detect single resources. |
alexanderjeurissen
pushed a commit
that referenced
this pull request
May 21, 2015
Issue with model.get not a function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this addon!
I had an issue with activeRoute calling model.get() if model is present. For a model that is an Ember.RSVP.hash model, for example, this was failing. I added a line here to check if model has the get() function.
I see that you have filed an issue about this already, if this seems like a good solution, great.