Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just a small catch... formatting #105

Closed
wants to merge 5 commits into from
Closed

Just a small catch... formatting #105

wants to merge 5 commits into from

Conversation

allanwsilva
Copy link
Contributor

No description provided.

ssaasi and others added 5 commits May 27, 2016 13:52
@ssaasi
changed method invocation amse.toggle_check_node() to toggle_check_no…
e0ef855 
…de(), removing the object name from the method call in toggle-checked-state-on-label-click.js.

That prefix is causing *NOT* to trigger the method properly.
@ssaasi
removing rubbish from .gitignore
debec3d
@ssaasi
getting some things back into .gitignore
6a52c4a
@allanwsilva
Just a small catch... formatting
e622f73
@ssaasi
Merge branch 'master' of https://github.com/alexandernst/angular-mult…
f2bdddf 
…i-select

# Conflicts:
#	.gitignore
@alexandernst
Copy link
Owner

input is a void element, thus it doesn't have a closing tag.

@allanwsilva
Copy link
Contributor Author

I know it is void, just to be HTML5 compliant... anyway, up to you merge it
or not.

Em ter, 14 de jun de 2016 às 16:32, Alexander Nestorov <
notifications@github.com> escreveu:

input is a void element, thus it doesn't have a closing tag.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#105 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFadS9jR9UI8eNNNveaYqzr7hlQ3aiisks5qLksHgaJpZM4I07UP
.

Allan Wojcik da Silva

@alexandernst
Copy link
Owner

I'm not sure what do you mean with HTML5 compliant. https://www.w3.org/TR/html5/syntax.html#void-elements specs from HTML5 say that input is void, thus it shouldn't have a closing tag. Maybe I'm missing something?

@alexandernst alexandernst reopened this Jun 14, 2016
@allanwsilva
Copy link
Contributor Author

You're right, please delete this pull request.

Sorry about that,

Em ter, 14 de jun de 2016 às 17:29, Alexander Nestorov <
notifications@github.com> escreveu:

I'm not sure what do you mean with HTML5 compliant.
https://www.w3.org/TR/html5/syntax.html#void-elements specs from HTML5
say that input is void, thus it shouldn't have a closing tag. Maybe I'm
missing something?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#105 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFadS7Q9WiofmFfz9wxk0TJ7nX0gbCcfks5qLlhlgaJpZM4I07UP
.

Allan Wojcik da Silva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allanwsilva @alexandernst @ssaasi