Skip to content

Commit

Permalink
Rules: Return 404 when DID rules not found. Fixes rucio#6334
Browse files Browse the repository at this point in the history
  • Loading branch information
alexanderrichards committed Nov 22, 2023
1 parent 289e964 commit 1fd25ec
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion lib/rucio/api/rule.py
Expand Up @@ -17,7 +17,7 @@

from rucio.api.permission import has_permission
from rucio.common.config import config_get_bool
from rucio.common.exception import AccessDenied
from rucio.common.exception import AccessDenied, RuleNotFound
from rucio.common.schema import validate_schema
from rucio.common.types import InternalAccount, InternalScope
from rucio.common.utils import api_update_return_dict
Expand Down Expand Up @@ -159,10 +159,15 @@ def list_replication_rules(filters={}, vo='def', *, session: "Session"):
account = '*'
filters['account'] = InternalAccount(account=account, vo=vo)

count = 0
rules = rule.list_rules(filters, session=session)
for r in rules:
count += 1
yield api_update_return_dict(r, session=session)

if count == 0:
raise RuleNotFound(f"No rules found for filters: {filters}")


@read_session
def list_replication_rule_history(rule_id, issuer, vo='def', *, session: "Session"):
Expand Down

0 comments on commit 1fd25ec

Please sign in to comment.